Change demand information for foreign calls
authorLuite Stegeman <stegeman@gmail.com>
Thu, 12 Nov 2015 10:13:54 +0000 (11:13 +0100)
committerBen Gamari <ben@smart-cactus.org>
Thu, 12 Nov 2015 10:14:09 +0000 (11:14 +0100)
Foreign calls may not be strict for lifted arguments. Fixes Trac #11076.

Test Plan: ./validate

Reviewers: simonpj, bgamari, austin

Subscribers: thomie

Differential Revision: https://phabricator.haskell.org/D1464

GHC Trac Issues: #11076

compiler/basicTypes/MkId.hs
testsuite/tests/stranal/should_run/T11076.hs [new file with mode: 0644]
testsuite/tests/stranal/should_run/T11076.stdout [new file with mode: 0644]
testsuite/tests/stranal/should_run/T11076A.hs [new file with mode: 0644]
testsuite/tests/stranal/should_run/T11076_prim.cmm [new file with mode: 0644]
testsuite/tests/stranal/should_run/all.T
testsuite/tests/stranal/sigs/T8598.stderr

index 0fa0005..c2a3678 100644 (file)
@@ -990,8 +990,11 @@ mkFCallId dflags uniq fcall ty
     (_, tau)        = tcSplitForAllTys ty
     (arg_tys, _)    = tcSplitFunTys tau
     arity           = length arg_tys
-    strict_sig      = mkClosedStrictSig (replicate arity evalDmd) topRes
 
+    strict_sig      = mkClosedStrictSig (replicate arity topDmd) topRes
+    -- the call does not claim to be strict in its arguments, since they
+    -- may be lifted (foreign import prim) and the called code doen't
+    -- necessarily force them. See Trac #11076.
 {-
 ************************************************************************
 *                                                                      *
diff --git a/testsuite/tests/stranal/should_run/T11076.hs b/testsuite/tests/stranal/should_run/T11076.hs
new file mode 100644 (file)
index 0000000..f095cc1
--- /dev/null
@@ -0,0 +1,15 @@
+{-
+   Test case for a problem where GHC had incorrect strictness
+   information for foreign calls with lifted arguments
+ -}
+{-# OPTIONS_GHC -O0 #-}
+module Main where
+
+import T11076A
+import Control.Exception
+x :: Bool
+x = error "OK: x has been forced"
+
+main :: IO ()
+main = print (testBool x) `catch`
+          \(ErrorCall e) -> putStrLn e -- x should be forced
diff --git a/testsuite/tests/stranal/should_run/T11076.stdout b/testsuite/tests/stranal/should_run/T11076.stdout
new file mode 100644 (file)
index 0000000..8a17d8b
--- /dev/null
@@ -0,0 +1 @@
+OK: x has been forced
diff --git a/testsuite/tests/stranal/should_run/T11076A.hs b/testsuite/tests/stranal/should_run/T11076A.hs
new file mode 100644 (file)
index 0000000..153a887
--- /dev/null
@@ -0,0 +1,21 @@
+{-# OPTIONS_GHC -O #-}
+{-# LANGUAGE MagicHash,
+             ForeignFunctionInterface,
+             UnliftedFFITypes,
+             GHCForeignImportPrim,
+             BangPatterns
+  #-}
+module T11076A where
+
+import GHC.Exts
+import Unsafe.Coerce
+
+{-
+   If the demand type for the foreign call argument is incorrectly strict,
+   the bang pattern can be optimized out
+ -}
+testBool :: Bool -> Int
+testBool !x = I# (cmm_testPrim (unsafeCoerce x))
+{-# INLINE testBool #-}
+
+foreign import prim "testPrim" cmm_testPrim :: Any -> Int#
diff --git a/testsuite/tests/stranal/should_run/T11076_prim.cmm b/testsuite/tests/stranal/should_run/T11076_prim.cmm
new file mode 100644 (file)
index 0000000..6e738a7
--- /dev/null
@@ -0,0 +1,10 @@
+#include "Cmm.h"
+#include "MachDeps.h"
+
+testPrim(gcptr x)
+{
+  W_ a;
+  a = 123;
+  return (a);
+}
+
index 8a82ce8..efd1afa 100644 (file)
@@ -10,3 +10,4 @@ test('T7649', normal, compile_and_run, [''])
 test('T9254', normal, compile_and_run, [''])
 test('T10148', normal, compile_and_run, [''])
 test('T10218', normal, compile_and_run, [''])
+test('T11076', normal, multimod_compile_and_run, ['T11076.hs', 'T11076_prim.cmm'])
index 28d5dd0..477d408 100644 (file)
@@ -1,6 +1,6 @@
 
 ==================== Strictness signatures ====================
 T8598.$trModule: m
-T8598.fun: <S(S),1*U(U)>m
+T8598.fun: <S,1*U(U)>m