Fix binary linking errors on Solaris
authorKarel Gardas <karel.gardas@centrum.cz>
Mon, 13 Jan 2014 23:00:18 +0000 (17:00 -0600)
committerAustin Seipp <austin@well-typed.com>
Tue, 14 Jan 2014 09:46:07 +0000 (03:46 -0600)
The -u option must be placed before libraries which define the necessary
symbols.

Signed-off-by: Austin Seipp <austin@well-typed.com>
compiler/main/DriverPipeline.hs

index df0f8e6..a95c179 100644 (file)
@@ -1800,7 +1800,16 @@ linkBinary' staticLink dflags o_files dep_packages = do
                                  -- HS packages, because libtool doesn't accept other options.
                                  -- In the case of iOS these need to be added by hand to the
                                  -- final link in Xcode.
-            else package_hs_libs ++ extra_libs ++ other_flags
+            else other_flags ++ package_hs_libs ++ extra_libs -- -Wl,-u,<sym> contained in other_flags
+                                                              -- needs to be put before -l<package>,
+                                                              -- otherwise Solaris linker fails linking
+                                                              -- a binary with unresolved symbols in RTS
+                                                              -- which are defined in base package
+                                                              -- the reason for this is a note in ld(1) about
+                                                              -- '-u' option: "The placement of this option
+                                                              -- on the command line is significant.
+                                                              -- This option must be placed before the library
+                                                              -- that defines the symbol."
 
     pkg_framework_path_opts <-
         if platformUsesFrameworks platform