Delete Ord Unique
authorBartosz Nitka <niteria@gmail.com>
Wed, 29 Jun 2016 14:34:55 +0000 (07:34 -0700)
committerBartosz Nitka <niteria@gmail.com>
Thu, 30 Jun 2016 12:55:51 +0000 (05:55 -0700)
commitfb6e2c7fe213004c7398a13e3cc38d4428b66b12
tree0bd461ec64d6eddb87ec40f0d01735ba5fbac85a
parente8d62711e6cbc3065ee5e6f6a654667f02a0bcd1
Delete Ord Unique

Ord Unique can be a source of invisible, accidental
nondeterminism as explained in Note [No Ord for Unique].
This removes it, leaving a note with rationale.

It's unfortunate that I had to write Ord instances for
codegen data structures by hand, but I believe that it's a
right trade-off here.

Test Plan: ./validate

Reviewers: simonmar, austin, bgamari

Reviewed By: simonmar

Subscribers: thomie

Differential Revision: https://phabricator.haskell.org/D2370

GHC Trac Issues: #4012
compiler/basicTypes/DataCon.hs
compiler/basicTypes/DataCon.hs-boot
compiler/basicTypes/Module.hs
compiler/basicTypes/Unique.hs
compiler/cmm/CLabel.hs
compiler/cmm/CmmCommonBlockElim.hs
compiler/cmm/CmmExpr.hs
compiler/cmm/CmmNode.hs
compiler/nativeGen/Reg.hs