Drop accidental write-attributes request
authorTamar Christina <tamar@zhox.com>
Wed, 3 Oct 2018 13:34:56 +0000 (15:34 +0200)
committerKrzysztof Gogolewski <krz.gogolewski@gmail.com>
Wed, 3 Oct 2018 13:40:22 +0000 (15:40 +0200)
commitdeceb21b7ec64ae60377addc2679692ca500b6ae
tree15c97a02cf0eab901bbe510ad027b7ba11757515
parenta838ae3750d0744001f31f4cedad13acf47bd610
Drop accidental write-attributes request

Summary:
The new filesystem code accidentally asks for write attributes
permissions when doing read-only access.

I believe this is what's causing the GHC 8.6.1 tarballs to fail
when installed to a privileged location.
I haven't been able to reproduce the issue yet, but this permission
bit is wrong anyway.

Test Plan: I'm still trying to workout how to test that this works,
changing the permissions on the folder doesn't seem to reproduce
the error on a tarball I made from before the change.

Reviewers: bgamari, tdammers

Reviewed By: bgamari

Subscribers: tdammers, monoidal, rwbarton, carter

GHC Trac Issues: #15667

Differential Revision: https://phabricator.haskell.org/D5177
utils/fs/fs.c