Fix #15953 by consistently using dumpIfSet_dyn to print debug output
authorChaitanya Koparkar <ckoparkar@gmail.com>
Thu, 29 Nov 2018 23:45:07 +0000 (18:45 -0500)
committerRyan Scott <ryan.gl.scott@gmail.com>
Thu, 29 Nov 2018 23:45:19 +0000 (18:45 -0500)
commitdcf1f9268f6b338997f2c03891d7bc57da2ee78a
treeaf97fdc33de5ab91e187636377bf296cff45b095
parent9e3aaf8b58d0f0e12e2d19b6928b6c2461d58dda
Fix #15953 by consistently using dumpIfSet_dyn to print debug output

Summary:
In some modules we directly dump the debugging output to STDOUT
via 'putLogMsg', 'printInfoForUser' etc. However, if `-ddump-to-file`
is enabled, that output should be written to a file. Easily fixed.

Certain tests (T3017, Roles3, T12763 etc.) expect part of the
output generated by `-ddump-types` to be in 'PprUser' style. However,
generally we want all other debugging output to use 'PprDump'
style. `traceTcRn` and `traceTcRnForUser` help us accomplish this.

This patch also documents some missing flags in the users guide.

Reviewers: RyanGlScott, bgamari, hvr

Reviewed By: RyanGlScott

Subscribers: rwbarton, carter

GHC Trac Issues: #15953

Differential Revision: https://phabricator.haskell.org/D5382
13 files changed:
compiler/deSugar/Coverage.hs
compiler/ghci/Debugger.hs
compiler/main/ErrUtils.hs
compiler/main/InteractiveEval.hs
compiler/main/Packages.hs
compiler/main/TidyPgm.hs
compiler/simplCore/SimplMonad.hs
compiler/typecheck/TcRnDriver.hs
compiler/typecheck/TcRnMonad.hs
docs/users_guide/debugging.rst
testsuite/tests/utils/should_run/Makefile
testsuite/tests/utils/should_run/T15953.hs [new file with mode: 0644]
testsuite/tests/utils/should_run/all.T