Fix recompilation detection when set of signatures to merge changes.
authorEdward Z. Yang <ezyang@cs.stanford.edu>
Mon, 12 Dec 2016 03:42:29 +0000 (19:42 -0800)
committerEdward Z. Yang <ezyang@cs.stanford.edu>
Tue, 13 Dec 2016 07:11:08 +0000 (23:11 -0800)
commitdb23ccfa2016902301a2fe71dedc2d6d3f3427be
tree3bd56b6ccdedf1fb308282a144acbee52c3c5d3b
parent24f6bec94411aa6c39a2c94ce5154ffe96ae330f
Fix recompilation detection when set of signatures to merge changes.

Summary:
Previously, we only checked to recompile if a signature we
previously depended on changed; however, if the -unit-id
settings changed, this could have resulted in more or less
signatures needing to be merged in; we weren't checking
for this case.

(Note that this logic is irrelevant for normal module imports,
which we also check using -unit-id, as we record each import
and redo it, forcing a recompile if the result changed.)

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>
Test Plan: validate

Reviewers: simonpj, austin, bgamari

Subscribers: thomie

Differential Revision: https://phabricator.haskell.org/D2832
15 files changed:
compiler/basicTypes/Module.hs
compiler/iface/MkIface.hs
testsuite/driver/extra_files.py
testsuite/tests/backpack/cabal/bkpcabal03/.gitignore [new file with mode: 0644]
testsuite/tests/backpack/cabal/bkpcabal03/Makefile [new file with mode: 0644]
testsuite/tests/backpack/cabal/bkpcabal03/Mod.hs [new file with mode: 0644]
testsuite/tests/backpack/cabal/bkpcabal03/Setup.hs [new file with mode: 0644]
testsuite/tests/backpack/cabal/bkpcabal03/all.T [new file with mode: 0644]
testsuite/tests/backpack/cabal/bkpcabal03/asig1/A.hsig [new file with mode: 0644]
testsuite/tests/backpack/cabal/bkpcabal03/asig1/asig1.cabal [new file with mode: 0644]
testsuite/tests/backpack/cabal/bkpcabal03/asig2/A.hsig [new file with mode: 0644]
testsuite/tests/backpack/cabal/bkpcabal03/asig2/asig2.cabal [new file with mode: 0644]
testsuite/tests/backpack/cabal/bkpcabal03/bkpcabal03.cabal.in1 [new file with mode: 0644]
testsuite/tests/backpack/cabal/bkpcabal03/bkpcabal03.cabal.in2 [new file with mode: 0644]
testsuite/tests/backpack/cabal/bkpcabal03/bkpcabal03.stderr [new file with mode: 0644]