revert '-Wl' prefixing to *_LD_OPTS
authorSergei Trofimovich <siarheit@google.com>
Sat, 17 Dec 2016 13:30:41 +0000 (13:30 +0000)
committerSergei Trofimovich <siarheit@google.com>
Sat, 17 Dec 2016 16:47:58 +0000 (16:47 +0000)
commita6657bd0d6b9949098021d89ed3cd8a943bdd3b6
tree033135d8896353e58b22407ebdc13b3f4f191c5a
parent2fa00f5b22dd9ea39eb1f5c9b52bbdbca0a37925
revert '-Wl' prefixing to *_LD_OPTS

This reverts f48f5a9ebf384e1e157b7b413e1d779f4289ddd2

The prefixing does not work as comma
is stripped by $(addprefix) macro:

The following call
    $$(addprefix -optl-Wl, $$($1_$2_$3_ALL_LD_OPTS))

prefixes options with "-optl-Wl" not with "-optl-Wl,"

The simplest breakage can be seen by adding
    SRC_LD_OPTS += -O1
to mk/build.mk:

  <no location info>: error:
    Warning: Couldn't figure out linker information!
             Make sure you're using GNU ld, GNU gold
             or the built in OS X linker, etc.
  gcc: error: unrecognized command line option '-Wl-O1'

Another problem with original change is loss of ability
to pass options to gcc as a linker driver, for example:
    SRC_LD_OPTS += -flto

Signed-off-by: Sergei Trofimovich <siarheit@google.com>
rules/distdir-way-opts.mk