Drop accidental write-attributes request
authorTamar Christina <tamar@zhox.com>
Wed, 3 Oct 2018 13:34:56 +0000 (15:34 +0200)
committerBen Gamari <ben@smart-cactus.org>
Fri, 5 Oct 2018 22:48:18 +0000 (18:48 -0400)
commita2e3334c0eaf249c5bc105c2ac15ef2ac84d78a0
treefe37a8485a34849221fd50c5bd34d22d872687dd
parentbf256ef23e86b6bac16595d10e3bd9cf4b548b19
Drop accidental write-attributes request

Summary:
The new filesystem code accidentally asks for write attributes
permissions when doing read-only access.

I believe this is what's causing the GHC 8.6.1 tarballs to fail
when installed to a privileged location.
I haven't been able to reproduce the issue yet, but this permission
bit is wrong anyway.

Test Plan: I'm still trying to workout how to test that this works,
changing the permissions on the folder doesn't seem to reproduce
the error on a tarball I made from before the change.

Reviewers: bgamari, tdammers

Reviewed By: bgamari

Subscribers: tdammers, monoidal, rwbarton, carter

GHC Trac Issues: #15667

Differential Revision: https://phabricator.haskell.org/D5177

(cherry picked from commit deceb21b7ec64ae60377addc2679692ca500b6ae)
utils/fs/fs.c