Fix #10816 by renaming FixitySigs more consistently
authorRyan Scott <ryan.gl.scott@gmail.com>
Wed, 11 Oct 2017 12:43:37 +0000 (08:43 -0400)
committerRyan Scott <ryan.gl.scott@gmail.com>
Wed, 11 Oct 2017 12:43:37 +0000 (08:43 -0400)
commit9c3f73168a6f7f6632b6a3ffd2cfcd774976a7f1
treea4948cc0902b35453e49b39015463f92d762ba1f
parentf20cf982f126aea968ed6a482551550ffb6650cf
Fix #10816 by renaming FixitySigs more consistently

Summary:
#10816 surfaced because we were renaming top-level fixity
declarations with a different code path (`rnSrcFixityDecl`) than
the code path for fixity declarations inside of type classes, which
is not privy to names that exist in the type namespace. Luckily, the
fix is simple: use `rnSrcFixityDecl` in both places.

Test Plan: make test TEST=T10816

Reviewers: austin, bgamari, simonpj

Reviewed By: simonpj

Subscribers: simonpj, rwbarton, thomie

GHC Trac Issues: #10816

Differential Revision: https://phabricator.haskell.org/D4077
compiler/rename/RnBinds.hs
compiler/rename/RnSource.hs
testsuite/tests/rename/should_compile/T10816.hs [new file with mode: 0644]
testsuite/tests/rename/should_compile/all.T