Build system: renable -Wall on validate (base)
authorThomas Miedema <thomasmiedema@gmail.com>
Tue, 3 Nov 2015 22:17:35 +0000 (16:17 -0600)
committerAustin Seipp <austin@well-typed.com>
Tue, 3 Nov 2015 22:17:42 +0000 (16:17 -0600)
commit987d542749be3b53d8461fa5abb770f0b9d8ba5e
tree8d389b3a8d3f7f715ca95c1d532dab82d897a0ae
parent334fe4500c234e83f250f74679f7bbe20208abba
Build system: renable -Wall on validate (base)

Problem: 'SRC_HC_OPTS += -Wall' in 'mk/warnings.mk' was getting
overwritten by 'SRC_HC_OPTS = ...' in 'mk/flavours/*.mk'.

It didn't affect the compiler or most other libraries, because most
.cabal files define 'ghc-options: -Wall'.

Bug introduced in commit
2c24fd707f8650205bb574ffac5f376239af3723, when moving validate settings
from 'mk/validate-settings.mk' to 'mk/flavours/validate.mk'.

Reviewed By: austin

Differential Revision: https://phabricator.haskell.org/D1425
ghc.mk
libraries/base/Data/Semigroup.hs
libraries/base/GHC/Enum.hs
libraries/base/GHC/GHCi.hs
mk/warnings.mk