Fix unsafe usage of `is_iloc` selector in Ord instance for ImportSpec
authorMatthew Pickering <matthewtpickering@gmail.com>
Tue, 6 Dec 2016 18:09:55 +0000 (18:09 +0000)
committerMatthew Pickering <matthewtpickering@gmail.com>
Tue, 6 Dec 2016 22:14:22 +0000 (22:14 +0000)
commit6e4188abf36d3b489ff7c9586ca49fe922f2beb7
treef64ea818eb91bb2953367c426720d843b8b5e6af
parent19ae142364058e258122f4bb68ef4b9aa6e41890
Fix unsafe usage of `is_iloc` selector in Ord instance for ImportSpec

Summary:
This fixes tests rn017, T7672 and closed #12930.

Both these tests were self referential module imports through hs-boot
files. As a result, I am quite suspicious of what the ImpAll constructor is
used for. I had a brief hunt around but couldn't immediately see whether
it was necessary.

Reviewers: austin, bgamari

Subscribers: simonpj, thomie, nomeata

Differential Revision: https://phabricator.haskell.org/D2793

GHC Trac Issues: #12930
compiler/basicTypes/RdrName.hs