Suppress -Winaccessible-code in derived code
authorRyan Scott <ryan.gl.scott@gmail.com>
Tue, 24 Jul 2018 12:40:42 +0000 (14:40 +0200)
committerKrzysztof Gogolewski <krz.gogolewski@gmail.com>
Tue, 24 Jul 2018 12:40:42 +0000 (14:40 +0200)
commit44a7b9baa45c4ab939c7d996519b5e3de3e13c5a
tree83ec6fe267a57957bb499f14be9a1b4bb3becb7c
parente1b5a1174e42e390855b153015ce5227b3251d89
Suppress -Winaccessible-code in derived code

Summary:
It's rather unfortunate that derived code can produce inaccessible
code warnings (as demonstrated in #8128, #8740, and #15398), since
the programmer has no control over the generated code. This patch
aims to suppress `-Winaccessible-code` in all derived code. It
accomplishes this by doing the following:

* Generalize the `ic_env :: TcLclEnv` field of `Implication` to
  be of type `Env TcGblEnc TcLclEnv` instead. This way, it also
  captures `DynFlags`, which record the flag state at the time
  the `Implication` was created.
* When typechecking derived code, turn off `-Winaccessible-code`.
  This way, any insoluble given `Implication`s that are created when
  typechecking this derived code will remember that
  `-Winaccessible-code` was disabled.
* During error reporting, consult the `DynFlags` of an
  `Implication` before making the decision to report an inaccessible
  code warning.

Test Plan: make test TEST="T8128 T8740 T15398"

Reviewers: simonpj, bgamari

Reviewed By: simonpj

Subscribers: monoidal, rwbarton, thomie, carter

GHC Trac Issues: #8128, #8740, #15398

Differential Revision: https://phabricator.haskell.org/D4993
compiler/typecheck/TcErrors.hs
compiler/typecheck/TcInstDcls.hs
compiler/typecheck/TcRnTypes.hs
compiler/typecheck/TcSMonad.hs
compiler/typecheck/TcSimplify.hs
compiler/typecheck/TcUnify.hs
testsuite/tests/deriving/should_compile/T15398.hs [new file with mode: 0644]
testsuite/tests/deriving/should_compile/T8128.stderr [deleted file]
testsuite/tests/deriving/should_compile/T8740.stderr [deleted file]
testsuite/tests/deriving/should_compile/all.T