remove redundant condition checking in profiling RTS code
authorosa1 <omeragacan@gmail.com>
Wed, 2 Jul 2014 13:55:04 +0000 (08:55 -0500)
committerAustin Seipp <austin@well-typed.com>
Wed, 2 Jul 2014 13:55:04 +0000 (08:55 -0500)
Summary: A redundant condition checking is removed, as discussed in http://www.haskell.org/pipermail/ghc-devs/2014-June/005088.html

Test Plan: validate

Reviewers: simonmar, austin

Reviewed By: austin

Subscribers: simonmar, relrod, carter

Differential Revision: https://phabricator.haskell.org/D37

rts/Profiling.c

index 50c9c39..53f64a7 100644 (file)
@@ -619,10 +619,8 @@ actualPush_ (CostCentreStack *ccs, CostCentre *cc, CostCentreStack *new_ccs)
     ccsSetSelected(new_ccs);
 
     /* update the memoization table for the parent stack */
-    if (ccs != EMPTY_STACK) {
-        ccs->indexTable = addToIndexTable(ccs->indexTable, new_ccs, cc,
-                                          0/*not a back edge*/);
-    }
+    ccs->indexTable = addToIndexTable(ccs->indexTable, new_ccs, cc,
+                                      0/*not a back edge*/);
 
     /* return a pointer to the new stack */
     return new_ccs;