Actually fail in failIfEmitsConstraints
authorRichard Eisenberg <rae@cs.brynmawr.edu>
Thu, 1 Nov 2018 19:37:58 +0000 (15:37 -0400)
committerRichard Eisenberg <rae@cs.brynmawr.edu>
Thu, 1 Nov 2018 21:34:47 +0000 (17:34 -0400)
commit74ed9c1c1b26971133c7166663b9c966d2eaca08
tree67e545f02474a8036a23262dd864573105f5e7d9
parent255d2e323a8879a7296a5ab94e6cc49023e2c86e
Actually fail in failIfEmitsConstraints

The function TcHsType.failIfEmitsConstraints says that it fails.
It even does so in its name. But it didn't! It *reported* constraints
but didn't fail. Now it does.

This is important in tcHsClsInstType; see the comments therein.

This was discovered while looking at #15797, but that ticket
requires visible kind application to exhibit the bug; the test
case will come with the patch for #12045.
compiler/typecheck/TcHsType.hs
testsuite/tests/polykinds/T11520.stderr
testsuite/tests/rename/should_fail/T5951.stderr
testsuite/tests/rename/should_fail/rnfail026.stderr
testsuite/tests/typecheck/should_fail/T11563.stderr
testsuite/tests/typecheck/should_fail/T13909.stderr
testsuite/tests/typecheck/should_fail/T2994.stderr