Fix #14719 by using the setting the right SrcSpan
authorRyan Scott <ryan.gl.scott@gmail.com>
Fri, 26 Jan 2018 18:10:26 +0000 (13:10 -0500)
committerBen Gamari <ben@smart-cactus.org>
Fri, 26 Jan 2018 19:37:29 +0000 (14:37 -0500)
commit59fa7b32b018a91f81773ca676251a0b2761ef56
tree7de1fd6fbc78e43dbae6bba706ab489b69bf27b2
parenta55d581f8f2923560c3444253050b13fdf2dec10
Fix #14719 by using the setting the right SrcSpan

Currently, error messages that germane to GADT constructors
put the source span at only the first character in the constructor,
leading to insufficient caret diagnostics. This can be easily fixed
by using a source span that spans the entire constructor, instead of
just the first character.

Test Plan: make test TEST=T14719

Reviewers: alanz, bgamari, simonpj

Reviewed By: alanz, simonpj

Subscribers: simonpj, goldfire, rwbarton, thomie, carter

GHC Trac Issues: #14719

Differential Revision: https://phabricator.haskell.org/D4344
compiler/typecheck/TcTyClsDecls.hs
testsuite/tests/gadt/T14719.hs [new file with mode: 0644]
testsuite/tests/gadt/T14719.stderr [new file with mode: 0644]
testsuite/tests/gadt/all.T
testsuite/tests/polykinds/T9222.stderr