Fix incorrect retypecheck loop in -j (#14075)
authorEdward Z. Yang <ezyang@cs.stanford.edu>
Tue, 22 Aug 2017 12:44:25 +0000 (08:44 -0400)
committerBen Gamari <ben@smart-cactus.org>
Tue, 22 Aug 2017 15:09:05 +0000 (11:09 -0400)
commit4717ce8658f12f425aebd1fc7f7ad8fe04a81df5
tree9522a650e1555b849a3a88e114f1255d02dafc00
parentafc2f7989ea973f201a28d95abb24b22269c5256
Fix incorrect retypecheck loop in -j (#14075)

The parallel codepath was incorrectly retypechecking the
hs-boot ModIface prior to typechecking the hs file,
which was inconsistent with the non-parallel case.  The
non-parallel case gets it right: you don't want to retypecheck
the hs-boot file itself (forwarding its declarations to hs)
because you need it to be consistently knot-tied with itself
when you compare the interfaces.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>
Test Plan: validate

Reviewers: bgamari, simonpj, austin

Reviewed By: bgamari

Subscribers: duog, rwbarton, thomie

GHC Trac Issues: #14075

Differential Revision: https://phabricator.haskell.org/D3815
compiler/main/GhcMake.hs
testsuite/tests/driver/T14075/F.hs [new file with mode: 0644]
testsuite/tests/driver/T14075/F.hs-boot [new file with mode: 0644]
testsuite/tests/driver/T14075/Makefile [new file with mode: 0644]
testsuite/tests/driver/T14075/O.hs [new file with mode: 0644]
testsuite/tests/driver/T14075/T14075.stderr [new file with mode: 0644]
testsuite/tests/driver/T14075/T14075.stdout [new file with mode: 0644]
testsuite/tests/driver/T14075/V.hs [new file with mode: 0644]
testsuite/tests/driver/T14075/V.hs-boot [new file with mode: 0644]
testsuite/tests/driver/T14075/all.T [new file with mode: 0644]