Replace (SourceText,FastString) with StringLiteral data type
authorAlan Zimmerman <alan.zimm@gmail.com>
Sun, 2 Aug 2015 08:26:59 +0000 (10:26 +0200)
committerAlan Zimmerman <alan.zimm@gmail.com>
Sun, 2 Aug 2015 08:26:59 +0000 (10:26 +0200)
commit15dd7007275a5dcdae2c9f104773eceaa56590dc
tree9fe88a05942e8dc024e52d7f56830be3dae4899b
parent75504f300d4db33ff66cc1a572d473bdb23b6a42
Replace (SourceText,FastString) with StringLiteral data type

Summary:
Phab:D907 introduced SourceText for a number of data types, by replacing
FastString with (SourceText,FastString). Since this has an Outputable
instance, no warnings are generated when ppr is called on it, but
unexpected output is generated. See Phab:D1096 for an example of this.

Replace the (SourceText,FastString) tuples with a new data type,
```lang=hs
data StringLiteral = StringLiteral SourceText FastString
```

Update haddock submodule accordingly

Test Plan: ./validate

Reviewers: hvr, austin, rwbarton, trofi, bgamari

Reviewed By: trofi, bgamari

Subscribers: thomie, trofi, rwbarton, mpickering

Differential Revision: https://phabricator.haskell.org/D1101

GHC Trac Issues: #10692
14 files changed:
compiler/basicTypes/BasicTypes.hs
compiler/deSugar/DsExpr.hs
compiler/hsSyn/HsExpr.hs
compiler/hsSyn/HsImpExp.hs
compiler/iface/MkIface.hs
compiler/main/DriverMkDepend.hs
compiler/main/GhcMake.hs
compiler/parser/Parser.y
compiler/parser/RdrHsSyn.hs
compiler/rename/RnNames.hs
compiler/utils/Binary.hs
ghc/InteractiveUI.hs
testsuite/tests/ghc-api/annotations/stringSource.hs
utils/haddock